Repository navigation
docs(point): ShapeSolver JAX message reads MAX_CONTAINING_SIZE (PyAutoArray#583) - #753
Merged
Merged
Conversation
…m autoarray The rejection message and the xfail reason hard-coded the cap as "(15)". The message is now built at class creation from autoarray.structures.triangles.array.MAX_CONTAINING_SIZE (a NumPy-only module, so it is the same plain string with or without JAX), the class docstring names the constant instead of a number, and the tests pin the rendered constant rather than a literal. Follows PyAutoArray#583 (15 -> 20). Refs PyAutoLabs/PyAutoArray#583 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Sep 27, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
ShapeSolverJAX-rejection message and docstring now read the triangle cap fromautoarray.structures.triangles.array.MAX_CONTAINING_SIZE, so they no longer hard-code "(15)". This is a companion to PyAutoArray's 15 → 20 change (phase 4c, PyAutoLabs/PyAutoArray#583). The message cannot drift from the library value again. The import is NumPy-only (checked), so the message is the same plain string whether or not JAX is installed.API Changes
None — internal changes only. The
NotImplementedErrortext now readsMAX_CONTAINING_SIZE (<value>).See full details below.
Test Plan
test_shape_solver.pypins assert the rendered constant, including the xfail reason; shape-solver tests give 16 passed, 1 xfailed.Full API Changes (for automation & release notes)
Changed Behaviour
ShapeSolver._JAX_REJECTED_MESSAGEtext now quotes the liveMAX_CONTAINING_SIZEinstead of a literal 15.Upstream PR
PyAutoLabs/PyAutoArray#584
Part of PyAutoLabs/PyAutoArray#583.
Generated by the PyAutoLabs agent workflow.
🤖 Generated with Claude Code